-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added begin timestamp to reader #5
base: limit-store
Are you sure you want to change the base?
Conversation
deserializedMessage.content(), | ||
message.metaData().timestamp().toLocalDateTime()); | ||
messageStore.add(msg); | ||
LocalDateTime messageTimestamp = message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this ever be null ?
DeserializedMessage deserializedMessage = | ||
messageDeserializer.deserializeMessage(ByteBuffer.wrap(message.getData())); | ||
ReadMessage msg = | ||
new ReadMessage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about adding SID here for it to be displayed on frontend ?
} | ||
} | ||
} | ||
} | ||
|
||
private void deserializeMessage(MessageDeserializer messageDeserializer, Message message, LocalDateTime timestamp) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about using MessageDeserializer
filed from object directly instead of passing it as param ?
No description provided.