delete msg - check if receipt handle is valid - fixes #324 #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also the correct issue ref - #324
adamw
reviewed
Jan 15, 2021
|
|
||
| class ReceiptHandleIsInvalid(val queueName: String, receiptHandle: String) extends ElasticMQError { | ||
| val code = "ReceiptHandleIsInvalid" | ||
| val message = s"""The input receipt handle "$receiptHandle" is not a valid.""" |
There was a problem hiding this comment.
Suggested change
| val message = s"""The input receipt handle "$receiptHandle" is not a valid.""" | |
| val message = s"""The receipt handle "$receiptHandle" is not valid.""" |
adamw
reviewed
Jan 15, 2021
| @@ -20,3 +20,8 @@ class MessageDoesNotExist(val queueName: String, messageId: MessageId) extends E | |||
| val code = "MessageDoesNotExist" | |||
| val message = s"Message does not exist: $messageId in queue: $queueName" | |||
| } | |||
|
|
|||
| class ReceiptHandleIsInvalid(val queueName: String, receiptHandle: String) extends ElasticMQError { | |||
There was a problem hiding this comment.
maybe simply: InvalidReceiptHandle?
There was a problem hiding this comment.
Fixed, although I left the string used in the api error response to be ReceiptHandleIsInvalid, so it conforms to https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_DeleteMessage.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.