remove time dependent checks

softwaremill · Jun 6, 2020 · 530c941 · 530c941
1 parent 710bf89
commit 530c941
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 14 deletions.
diff --git a/retry/src/test/scala/PolicySpec.scala b/retry/src/test/scala/PolicySpec.scala
@@ -119,8 +119,7 @@ abstract class PolicySpec extends AsyncFunSpec with BeforeAndAfterAll {
       val runF = policy({ marker.set(System.currentTimeMillis); tries.next })
       runF.map { result =>
         val delta = marker.get() - marker_base
-        assert(success.predicate(result) == true &&
-          delta >= 90 && delta <= 200) // was 110, depends on how hot runtime is
+        assert(success.predicate(result) === true && delta >= 90) // was 110, depends on how hot runtime is
       }
     }
 
@@ -153,9 +152,7 @@ abstract class PolicySpec extends AsyncFunSpec with BeforeAndAfterAll {
       val runF = policy({ marker.set(System.currentTimeMillis); tries.next })
       runF.map { result =>
         val delta = marker.get() - marker_base
-        assert(
-          success.predicate(result) === true &&
-            delta >= 90 && delta <= 200) // was 110
+        assert(success.predicate(result) === true && delta >= 90) // was 110
       }
     }
 
@@ -239,9 +236,7 @@ abstract class PolicySpec extends AsyncFunSpec with BeforeAndAfterAll {
         policy({ marker.set(System.currentTimeMillis); tries.next }).map {
           result =>
             val delta = marker.get() - marker_base
-            assert(
-              success.predicate(result) === true &&
-                delta >= 0 && delta <= 2000)
+            assert(success.predicate(result) === true && delta >= 0)
         }
       }
 
@@ -256,9 +251,7 @@ abstract class PolicySpec extends AsyncFunSpec with BeforeAndAfterAll {
         policy({ marker.set(System.currentTimeMillis); tries.next }).map {
           result =>
             val delta = marker.get() - marker_base
-            assert(
-              success.predicate(result) === true &&
-                delta >= 0 && delta <= 2000)
+            assert(success.predicate(result) === true && delta >= 0)
         }
       }
 

diff --git a/retry/src/test/scala/SuccessSpec.scala b/retry/src/test/scala/SuccessSpec.scala
@@ -19,18 +19,18 @@ class SuccessSpec extends FunSpec {
   describe("retry.Success.option") {
     val option = implicitly[Success[Option[String]]]
     it("should be successful on Some(_)") {
-      assert(option.predicate(Some("")) == true)
+      assert(option.predicate(Some("")) === true)
     }
 
     it("should be a failure on None") {
-      assert(option.predicate(None) == false)
+      assert(option.predicate(None) === false)
     }
   }
 
   describe("retry.Success.tried") {
     val tried = implicitly[Success[Try[String]]]
     it("should be successful on Success(_)") {
-      assert(tried.predicate(Try("")) == true)
+      assert(tried.predicate(Try("")) === true)
     }
 
     it("should be failure on Failure(_)") {