Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy server support #10

Closed
adamw opened this issue Jul 28, 2017 · 13 comments
Closed

Proxy server support #10

adamw opened this issue Jul 28, 2017 · 13 comments

Comments

@adamw
Copy link
Member

adamw commented Jul 28, 2017

No description provided.

@robsonpeixoto
Copy link

@omainegra
Copy link
Contributor

Anybody working on this? I can take it

@adamw
Copy link
Member Author

adamw commented Aug 31, 2017

@omainegra go ahead :)

@adamw
Copy link
Member Author

adamw commented Sep 13, 2017

any luck with that issue maybe? :)

@omainegra
Copy link
Contributor

@adamw Still working on this, sorry for the delay but I got hit by Irma and electricity and internet just came back.

@adamw
Copy link
Member Author

adamw commented Sep 13, 2017

@omainegra sorry to hear that, hope that you & your family is fine! no hurry with the code, just checking :)

@atais
Copy link
Contributor

atais commented Sep 28, 2017

I would really like to see that working 👍

@adamw
Copy link
Member Author

adamw commented Oct 2, 2017

@omainegra hey, is everything fine? we didn't hear from you for a while

adamw added a commit that referenced this issue Oct 6, 2017
@adamw
Copy link
Member Author

adamw commented Oct 6, 2017

@omainegra I hope you are fine, for now I implemented proxy support as an option passed to the backend when creating it. Hope to hear from you in the future :)

@adamw adamw closed this as completed Oct 6, 2017
@adamw
Copy link
Member Author

adamw commented Oct 6, 2017

Released in 0.0.17

@atais
Copy link
Contributor

atais commented Oct 6, 2017

How can I use it with Monix Backend?

Also wouldn't it be better to try to read default java proxy parameters by default?

@adamw
Copy link
Member Author

adamw commented Oct 6, 2017

For example:

implicit val backend = AsyncHttpClientMonixBackend(
  options = SttpBackendOptions.httpProxy("some.host", 8080))

sttp.get(uri"...").send()

Sure, reading the default java proxy parameters is an option - though I don't like this style of "global" configuration. Maybe you'd like to attempt making a PR? :)

@atais
Copy link
Contributor

atais commented Oct 6, 2017

Maybe you'd like to attempt making a PR? :)

I sure will try 👍

Also, thanks for the example. I was using AsyncHttpClientMonixHandler back from 0.0.12 so that was why I could not find a proper option :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants