We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-up to a thread at Discourse.
For now, CatsMonadAsyncError uses the default implementation of blocking (see sttp.monad.MonadError#blocking):
CatsMonadAsyncError
blocking
sttp.monad.MonadError#blocking
def blocking[T](t: => T): F[T] = eval(t)
eval is implemented as follows (see sttp.client3.impl.cats.CatsMonadError#eval):
eval
sttp.client3.impl.cats.CatsMonadError#eval
override def eval[T](t: => T): F[T] = F.delay(t)
As a result, Sync[F].delay is used for blocking actions. That seems to be wrong.
Sync[F].delay
The text was updated successfully, but these errors were encountered:
Override blocking inside CatsMonadError
3d50b74
Fix softwaremill#1991
4c088b6
b0f1f9f
b554596
Successfully merging a pull request may close this issue.
Follow-up to a thread at Discourse.
For now,
CatsMonadAsyncError
uses the default implementation ofblocking
(seesttp.monad.MonadError#blocking
):eval
is implemented as follows (seesttp.client3.impl.cats.CatsMonadError#eval
):As a result,
Sync[F].delay
is used for blocking actions. That seems to be wrong.The text was updated successfully, but these errors were encountered: