Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comma is not interpreted correctly by uri interpolator #40

Closed
anatoliykmetyuk opened this issue Oct 31, 2017 · 2 comments
Closed

Comma is not interpreted correctly by uri interpolator #40

anatoliykmetyuk opened this issue Oct 31, 2017 · 2 comments

Comments

@anatoliykmetyuk
Copy link 

scala> import com.softwaremill.sttp._
import com.softwaremill.sttp._

scala> val a = "a"
a: String = a

scala> val b = "b"
b: String = b

scala> uri"http://example.com?q=$a,$b"
res0: com.softwaremill.sttp.Uri = http://example.com?q=a&q=,&q=b

scala> uri"http://example.com?q=${a + "," + b}"
res1: com.softwaremill.sttp.Uri = http://example.com?q=a,b

res0 should be equal to res1.
adamw added a commit that referenced this issue Oct 31, 2017
@adamw
#40: properly concatenating expression/token sequences in uri interpo…
2dcc31b 
…lator
@adamw
Copy link
Member

adamw commented Oct 31, 2017

Should be fixed in 1.0.2 - please check :)

@adamw adamw closed this as completed Oct 31, 2017
@anatoliykmetyuk
Copy link
Author

Great! Thank you for the quick fix @adamw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamw @anatoliykmetyuk