[WIP] Timeout exception #1630
Merged
[WIP] Timeout exception #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
Nov 15, 2022
docs/responses/exceptions.md
Outdated
|
|
||
| * `ConnectException`: when a connection (tcp socket) can't be established to the target host | ||
| * `ReadException`: when a connection has been established, but there's any kind of problem receiving the response (e.g. a broken socket) | ||
| * `TimeoutException`: a discriminated sub-kind of `ReadException` for timeout fails |
There was a problem hiding this comment.
sub-type - kind is a different thing :)
Pask423
previously approved these changes
Nov 15, 2022
Pask423
reviewed
Nov 15, 2022
| @@ -228,7 +228,7 @@ class FinagleBackend(client: Option[Client] = None) extends SttpBackend[TFuture, | |||
| Some(new SttpClientException.ConnectException(request, e)) | |||
| case e: com.twitter.finagle.ChannelClosedException => Some(new SttpClientException.ReadException(request, e)) | |||
| case e: com.twitter.finagle.IndividualRequestTimeoutException => | |||
| Some(new SttpClientException.ReadException(request, e)) | |||
| Some(new SttpClientException.TimeoutException(request, e)) | |||
There was a problem hiding this comment.
For sure it is the only backend that needs this change ?
There was a problem hiding this comment.
@Pask423 there are also individual adapters for Akka and Armeria in this PR. Other backends probably just emit standard java timeout exceptions.
There was a problem hiding this comment.
Yes, the unchanged backends emit java native exceptions.
kciesielski
reviewed
Nov 15, 2022
| @@ -228,7 +228,7 @@ class FinagleBackend(client: Option[Client] = None) extends SttpBackend[TFuture, | |||
| Some(new SttpClientException.ConnectException(request, e)) | |||
| case e: com.twitter.finagle.ChannelClosedException => Some(new SttpClientException.ReadException(request, e)) | |||
| case e: com.twitter.finagle.IndividualRequestTimeoutException => | |||
| Some(new SttpClientException.ReadException(request, e)) | |||
| Some(new SttpClientException.TimeoutException(request, e)) | |||
There was a problem hiding this comment.
@Pask423 there are also individual adapters for Akka and Armeria in this PR. Other backends probably just emit standard java timeout exceptions.
Pask423
approved these changes
Nov 15, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting pull request:
sbt compilesbt compileDocssbt testsbt scalafmt