Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding full logging options to log settings #2114

Merged

Conversation

Andrapyre
Copy link
Contributor

Description

There are use cases (e.g. when building a library on top of sttp) where it is useful to pass all logging options as a single parameter to the end user to specify. This PR adds a .logSettings method that takes an Option[LoggingOptions] parameter, instead of the individual logging options parameters (e.g. logRequestBody, etc.).

Before submitting pull request:

  • Check if the project compiles by running sbt compile
  • Verify docs compilation by running sbt compileDocs
  • Check if tests pass by running sbt test
  • Format code by running sbt scalafmt

@adamw adamw merged commit d8a8151 into softwaremill:master Mar 20, 2024
12 checks passed
@adamw
Copy link
Member

adamw commented Mar 20, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants