Support Streaming for Armeria backend #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Armeria natively supports Streaming through Reactive Streams Modifications: - Introduce `AbstractArmeriaBackend` for common conversions - Support streaming using `Publisher` of Reactive Streams - Add new modules for better interops with other libraries - FS2 - Monix - Cats - Scalaz - ZIO Result: Better interop Armeria with sttp.
ikhoon
force-pushed
the
armeria-streaming
branch
from
b4fc729
to
1b42d29
Compare
ikhoon
commented
Feb 14, 2021
| class ArmeriaZioHttpTest extends HttpTest[Task] with ZioTestBase { | ||
|
|
||
| // FIXME(ikhoon): A request failed with `ResponseTimeoutException`. | ||
| // However, "read exceptions - timeout" test never ends. |
There was a problem hiding this comment.
I don't know why read exceptions - timeout test never ends.
Can I get some advice?
There was a problem hiding this comment.
does this happen only for the zio backend? and both locally and on CI?
There was a problem hiding this comment.
- It only happens for the ZIO backend.
- It is reproducible locally.
There was a problem hiding this comment.
There was a bug in closing a client factory. The problem is fixed now.
|
/cc @ngbinh |
|
Awesome. 🤩 |
adamw
reviewed
Feb 16, 2021
adamw
reviewed
Feb 16, 2021
|
All known failed tests are fixed. Not sure that the failed tests in CI are related to this PR. |
|
@adamw Thanks for the quick merge. I left a comment on your revise. |
|
awesome! Will try armeria backend when the new sttp release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Armeria natively supports Streaming through Reactive Streams
Modifications:
AbstractArmeriaBackendfor common conversionsPublisherof Reactive StreamsResult:
Better interop Armeria with sttp.
Before submitting pull request:
sbt compilesbt compileDocssbt testsbt scalafmt