-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSocket concatenateFragmentedFrames
is a no-op
#3339
Comments
Do you see where the problem is? I guess it would be high time to add some tests for the |
Accumutor is always tapir/server/http4s-server/src/main/scala/sttp/tapir/server/http4s/Http4sWebSockets.scala Line 76 in fdfa3da
tapir/server/http4s-server/src/main/scala/sttp/tapir/server/http4s/Http4sWebSockets.scala Line 79 in fdfa3da
|
Question, if such functionality is actually needed. http4s concatenates web socket frames by default, not sure about the other servers. |
It is, not all servers do :) Though of course, can't tell right now which don't ;) I just remember this being the case ... |
But, astonishingly, nobody is complaining about non-concatenating the frames by tapir interpreter for other servers. |
Yes, maybe these are unpopular servers, or people don't send fragmented frames that often. I don't know really :) |
Current implementation of
optionallyConcatenateFrames
returns the original stream:tapir/server/http4s-server/src/main/scala/sttp/tapir/server/http4s/Http4sWebSockets.scala
Line 71 in fdfa3da
The text was updated successfully, but these errors were encountered: