Fix tapir on scala 3.4.0: an incorrect form of a tuple type being generated #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was found by the Scala 3 open CommunityBuild, and caused the macro expansion of the tests to fail compilation on scala 3.4.0. The previous implementation generated types which then could not be "inline matched" by the newer compiler, but somehow managaed to go through the cracks of the older compiler.
|
Thanks :) Not sure why these are in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was found by the scala 3 open community build, and caused the macro expansion of the tests to fail compilation on scala 3.4.0. The previous implementation generated types which then later could not be "inline matched" by the newer compiler (generating new compile time errors), but somehow managed to go through the cracks of the older compiler. Those types would have shape like:
(a type applied with wildcards, and also applied with correct types).
This PR fixes the implementation, so that the macro expansion will be successful for users using tapir on scala 3.4.0.
Underlying issue and fix found by @nicolasstucki
More information: scala/scala3#19458