Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wordsmith type-erasure issue with status mappings #755

Merged
merged 2 commits into from Sep 18, 2020
Merged

wordsmith type-erasure issue with status mappings #755

merged 2 commits into from Sep 18, 2020

Conversation

andyczerwonka
Copy link
Contributor

I was going through the docs and was a little confused by the note around type erasure, so I tried to simplify it a bit.

@adamw
Copy link
Member

adamw commented Sep 18, 2020

Thanks, indeed looks better :). One thing that is missing, though, is information that this will fail at compile-time, due to the macro checking if the erased types aren't the same.

@andyczerwonka
Copy link
Contributor Author

One thing that is missing, though, is information that this will fail at compile-time, due to the macro checking if the erased types aren't the same

Good point, I added that back in.

@adamw adamw merged commit 1077b5d into softwaremill:master Sep 18, 2020
@adamw
Copy link
Member

adamw commented Sep 18, 2020

Thanks again! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants