Add option to specify custom class names for OpenAPI and AsyncAPI schemas #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I and AsyncAPI docs
adamw
reviewed
Feb 3, 2021
| publishOperationId: (Vector[String], Endpoint[_, _, _, _]) => String | ||
| subscribeOperationId: (Vector[String], Endpoint[_, _, _, _]) => String, | ||
| publishOperationId: (Vector[String], Endpoint[_, _, _, _]) => String, | ||
| schemaObjectInfoToNameMapper: SObjectInfo => String = SObjectInfo.defaultToNameMapper |
There was a problem hiding this comment.
maybe let's use a simpler name - I think just schemaName would be sufficient, the rest is obvious from the type signature
adamw
reviewed
Feb 3, 2021
| @@ -73,6 +73,10 @@ object SchemaType { | |||
| case class SObjectInfo(fullName: String, typeParameterShortNames: List[String] = Nil) | |||
| object SObjectInfo { | |||
| val Unit: SObjectInfo = SObjectInfo(fullName = "Unit") | |||
| val defaultToNameMapper: SObjectInfo => String = info => { | |||
There was a problem hiding this comment.
this is only used for openapi/asyncapi generation, so I'd keep that code for use only in these modules. Maybe the package object sttp.tapir.docs.apispec would be a good place?
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.