Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T21] Specify standard reference system on subsurface #42

Open
santisoler opened this issue Apr 17, 2021 · 0 comments
Open

[T21] Specify standard reference system on subsurface #42

santisoler opened this issue Apr 17, 2021 · 0 comments

Comments

@santisoler
Copy link
Member

In order to make any to_subsurface() or from_subsurface() function to work seamlessly on every library that wants to implement them, we would need to determine a standard reference system on subsurface.
This way, if a given library A converts their data structures to a subsurface object, another library B can open it without having to worry about how A defines their coordinates.

After a brainstorming with @Leguark , we ended up in some conclusions:

  • subsurface should use a right-handed coordinate system with z axis point upwards and x and y axis as horizontal ones.
  • There will be no assumption on the direction of x and y coordinates: they can either be pointing towards east and north, respectively, or towards southwest and southeast, respectively.
  • Each library should manage their own coordinate conversions on their to_subsurface() and from_subsurface() functions.

These choices are based on the default reference system in PyVista, which sounds very rational.
This means that we would keep a fairly easy way to plot subsurface objects in PyVista.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant