Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkFilter): properly set all available global variables #4830

Merged
merged 1 commit into from Sep 24, 2021

Conversation

sogehige
Copy link
Collaborator

CHECKLIST

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #4830 (ee6e282) into master (1b205ac) will increase coverage by 5.08%.
The diff coverage is 74.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4830      +/-   ##
==========================================
+ Coverage   44.62%   49.71%   +5.08%     
==========================================
  Files         560      411     -149     
  Lines       23298    20263    -3035     
  Branches     3574     3426     -148     
==========================================
- Hits        10397    10073     -324     
+ Misses      12901    10190    -2711     
Flag Coverage Δ
mysql 23.14% <17.46%> (-30.00%) ⬇️
postgres ?
sqlite 49.63% <74.60%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helpers/checkFilter.ts 79.56% <73.33%> (-12.33%) ⬇️
src/message.ts 87.58% <100.00%> (+4.25%) ⬆️
src/helpers/sql.ts 76.47% <0.00%> (-23.53%) ⬇️
src/helpers/getMigrationType.ts 80.00% <0.00%> (-20.00%) ⬇️
src/updater.ts 63.88% <0.00%> (-5.56%) ⬇️
src/database/entity/_transformer.ts 73.91% <0.00%> (-4.35%) ⬇️
src/systems/top.ts 97.26% <0.00%> (-2.19%) ⬇️
src/systems/bets.ts 66.66% <0.00%> (-1.64%) ⬇️
src/systems/points.ts 65.48% <0.00%> (-1.62%) ⬇️
src/games/gamble.ts 93.47% <0.00%> (-1.09%) ⬇️
... and 153 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b205ac...ee6e282. Read the comment docs.

@sogehige sogehige merged commit 880ef77 into master Sep 24, 2021
@sogehige sogehige deleted the checkFilterFix branch September 24, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant