Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer Overflow for indexes for commands #5

Open
sogggy opened this issue Nov 13, 2020 · 1 comment
Open

Integer Overflow for indexes for commands #5

sogggy opened this issue Nov 13, 2020 · 1 comment

Comments

@sogggy
Copy link
Owner

sogggy commented Nov 13, 2020

Perhaps integer overflow cases should be handled for indexes for commands such as add, edit etc.

image.png
Error message if there is overflow.

image.png
Error message if there is no overflow.

Even though they are both postive numbers, their error messages are different, which implies that overflow was not handled properly.

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 18, 2020

Team's Response

Error presents in AB3.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: This case should have been covered by developers though, as it leads to misleading error messages thrown.


❓ Issue type

Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]

  • I disagree

Reason for disagreement: This is a functionality bug as it causes the application to work unexpectedly. (App is not expected to throw error that appears when negative number is entered).


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants