New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for deprecated CMake options #187

Open

stv0g opened this issue Feb 8, 2023 · 0 comments

Labels

Contributor

stv0g commented Feb 8, 2023

In #168 we harmonized CMake option names.
To keep compatability with existing build-trees and scripts we kept suporting the old names.

They should be removed some time in the future.

The deprecated CMake options are:

option(WITH_EIGEN_MODULE     "Fetch Eigen3 as module (deprecated option)" OFF)
option(WITH_SPDLOG_SUBMODULE "Fetch spdlog as module (deprecated option)" OFF)
option(WITH_CIM_SUBMODULE    "Fetch CIMpp as module (deprecated option)" OFF)
option(WITH_PYBIND_MODULE    "Fetch pybind11 as module (deprecated option)" OFF)
option(GET_GRID_DATA     	   "Fetch grid data (deprecated option)" ON)

stv0g added the enhancement label

stv0g mentioned this issue

Cleanup of CMake and Docker files #168

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment