Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix check for VCPKG_TOOLCHAIN in Cmake files #219

Merged
merged 3 commits into from
May 18, 2022

Conversation

holmes1412
Copy link
Contributor

Make checks on VCPKG stricter. Also add target_link snappy and lz4 to tutorials and benchmarks.

For those who just use VCPKG to install some other dependencies instead of SRPC, we won't find srpc in ${CMAKE_INSTALL_PREFIX}/tools/srpc. Refer to #216

@luciouskami
Copy link
Contributor

依赖项确实是加进去了,但是缺少了vcpkg的路径
正确的路径应该是类似这样的:
1
然后snappy和lz4的路径:
2

应该还是没有搜索到,仅仅只加了lib进去

@holmes1412
Copy link
Contributor Author

明白了,少了find_package和find_library去找路径了~晚点我改完再找你帮试试~非常感谢>_<

@luciouskami
Copy link
Contributor

明白了,少了find_package和find_library去找路径了~晚点我改完再找你帮试试~非常感谢>_<

好的

@holmes1412
Copy link
Contributor Author

应该可以解决tutorial两个压缩库寻找依赖路径的问题了,麻烦帮看看windows下是否还有问题~

@luciouskami
Copy link
Contributor

luciouskami commented May 17, 2022

应该可以解决tutorial两个压缩库寻找依赖路径的问题了,麻烦帮看看windows下是否还有问题~

看起来lz4路径仍然不正确:
在工程中生成的路径是:LZ4::LZ4.lib
1
cmake提示如下:
1

我猜可能是这样的 库是找到了,但是在类似 181行的地方 link的时候link的路径不正确?

@holmes1412
Copy link
Contributor Author

感谢提供的线索,更正了写法,把find_library的全路径写进去了~有空的话可以再帮看看~

@luciouskami
Copy link
Contributor

木有问题啦,windows下编译通过

@holmes1412
Copy link
Contributor Author

感动哭QWQ感谢小伙伴~

@luciouskami
Copy link
Contributor

感动哭QWQ感谢小伙伴~

感谢耐心解答和修复,酱紫windows上开发就没什么问题了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants