Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CustomModule for RPC and Http. #396

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Add CustomModule for RPC and Http. #396

merged 3 commits into from
Jul 10, 2024

Conversation

holmes1412
Copy link
Contributor

Barenboim
Barenboim reviewed Jul 2, 2024
View reviewed changes
src/http/http_module.h Outdated
@@ -41,6 +41,8 @@ class HttpMetricsModule : public MetricsModule
bool server_begin(SubTask *task, RPCModuleData& data) override;
};

using HttpCustomModule = MetricsModule;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里好像不太对。

@holmes1412 holmes1412 force-pushed the master branch 3 times, most recently from 9284ae6 to fbffa2f Compare July 4, 2024 15:23
Barenboim
Barenboim reviewed Jul 4, 2024
View reviewed changes
src/rpc_server.h Outdated
{
if (!module->server_task_begin(server_task, *task_data))
{
status_code = RPCStatusModuleFilterFailed;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也缩进太多层了。

@Barenboim Barenboim merged commit abeac13 into sogou:master Jul 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barenboim Barenboim Barenboim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@holmes1412 @Barenboim