Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling #123

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Better error handling #123

merged 1 commit into from
Mar 24, 2022

Conversation

benny-n
Copy link
Collaborator

@benny-n benny-n commented Mar 21, 2022

  • create custom AppError enum
  • impl actix trait ResponseError for AppError
  • move logging into the trait implementation
  • refactor all the error handling in the server

@benny-n
Better error handling
900dd2e 
 - create custom `AppError` enum
 - impl actix trait `ResponseError` for `AppError`
 - move logging into the trait implementation
 - refactor all the error handling in the server
@benny-n benny-n added 📁 server App: Server 💡 refactor Type: Refactor labels Mar 21, 2022
@benny-n benny-n requested a review from liadaram1 March 21, 2022 13:31
@benny-n benny-n merged commit 1e17138 into development Mar 24, 2022
@benny-n benny-n deleted the better-error-handling branch March 24, 2022 22:32
@benny-n benny-n mentioned this pull request Mar 24, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liadaram1 liadaram1 liadaram1 left review comments

Assignees
No one assigned
Labels
💡 refactor Type: Refactor 📁 server App: Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benny-n @liadaram1