Simplify core functions logic #41

liadaram1 · 2021-12-31T17:07:43Z

Simplify the choose course logic according to the new method with the pdf grade sheet.
Reduce code duplication in the tests module by using a macro.
Remove ug parser support.
Add another test for the core function with extensive edge cases.

Code compiles, need to be checked.

packages/server/src/user.rs

liadaram1 and others added 8 commits December 27, 2021 00:39

Refactor the way we iterate over course list according to the new method

7d440ca

Code compiles, need to be checked.

update test of legendary funcion and fix some bugs

d55281c

reduce some code duplication

97f396c

remove code duplication in tests

1ca8cac

remove ug parser + small changes to pdf parser

780a1aa

using macro to reduce code duplication in tests module

6b835c3

Adding another test for core function

88bbc2d

fmt and dlippty

b64c236

benny-n requested changes Dec 31, 2021

View reviewed changes

packages/server/src/user.rs Outdated Show resolved Hide resolved

benny-n linked an issue Dec 31, 2021 that may be closed by this pull request

Reduce code duplication in core tests #40

Closed

benny-n mentioned this pull request Dec 31, 2021

Stop supporting exporting grades from UG #39

Closed

3 tasks

change mut self to self

bd913ad

benny-n approved these changes Jan 2, 2022

View reviewed changes

liadaram1 merged commit ba94e9b into master Jan 2, 2022

liadaram1 deleted the simplify-choose-courses-logic branch January 2, 2022 12:41

Provide feedback