Fix race in patricia tree #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a major issue added in 703b087. There are still wins on allocation though. benchmark old ns/op new ns/op delta BenchmarkCMuxConnHTTP1-4 783 836 +6.77% BenchmarkCMuxConnHTTP2-4 895 806 -9.94% BenchmarkCMuxConnHTTP1n2-4 1000 1026 +2.60% BenchmarkCMuxConnHTTP2n1-4 916 961 +4.91% benchmark old allocs new allocs delta BenchmarkCMuxConnHTTP1-4 3 4 +33.33% BenchmarkCMuxConnHTTP2-4 4 4 +0.00% BenchmarkCMuxConnHTTP1n2-4 4 5 +25.00% BenchmarkCMuxConnHTTP2n1-4 4 5 +25.00% benchmark old bytes new bytes delta BenchmarkCMuxConnHTTP1-4 272 280 +2.94% BenchmarkCMuxConnHTTP2-4 304 304 +0.00% BenchmarkCMuxConnHTTP1n2-4 304 312 +2.63% BenchmarkCMuxConnHTTP2n1-4 304 312 +2.63%
This was referenced Jul 15, 2016
|
lgtm |
|
Thanks Tamir! |
tamird
pushed a commit
to cockroachdb/cmux
that referenced
this pull request
Jul 15, 2016
Fix race in patricia tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @tamird