설정 UI와 데이터 분리 #100
Merged
설정 UI와 데이터 분리 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting.html에 마크업으로 하드코딩 되어있는 설정 항목을 일정한 규칙에 맞게 JS Object로 만들어 분리하고, 설정 창이 로드될 때 UI를 동적으로 빌드하도록 하였습니다. 자세한 내용과 배경은 그때 DM 토론으로 이야기 했었구요.일단 제가 하나하나 테스트 했을 때는 문제가 없었는데, 혹시 모르니까 각자 컴퓨터에서 다시 한번 모든 설정 항목을 테스트해서 설정값이 실제로 적용이 되는지 확인해 주세요 ><...
그리고 설정 화면에 큰 변화가 있는 PR이니만큼, 이 풀 리퀘스트의 머지 여부가 확정되기 전까지는 TDP 설정 항목을 변경하는 PR은 보류해 주세요 \ ._.)/