Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.x] Add parameter to prefix the route URLs #57

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

xiCO2k
Copy link
Contributor

@xiCO2k xiCO2k commented Sep 25, 2021

This PR adds the capability to add a pathPrefix to all the urls.

The main usage will be to people that use proxies like traefik or k8s ingress controller, this way on a domain https://example.com can the be web server and https://example.com/ws will be the pWS server both working on the same port.

Hope this is helpful.
Thanks,
Francisco

@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #57 (3fe620f) into master (e5a085d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   86.64%   86.66%   +0.01%     
==========================================
  Files          35       35              
  Lines        1565     1567       +2     
  Branches      262      262              
==========================================
+ Hits         1356     1358       +2     
  Misses        208      208              
  Partials        1        1              
Impacted Files Coverage Δ
src/server.ts 88.49% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a085d...3fe620f. Read the comment docs.

@rennokki rennokki changed the title Add PathPrefix param [0.x] Add parameter to prefix the route URLs Sep 29, 2021
@rennokki rennokki merged commit eb6555d into soketi:master Sep 29, 2021
@xiCO2k xiCO2k deleted the add-pathPrefix-param branch September 29, 2021 14:50
@xiCO2k xiCO2k mentioned this pull request Sep 29, 2021
@willpower232
Copy link

@xiCO2k thank you for your efforts, can I ask how you implemented this client side? pusher-js is pretty adamant that nothing should be before /app 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants