Merge 9e6858f into c4b868b

sokil · Feb 3, 2023 · 1d96d91 · 1d96d91
2 parents c4b868b + 9e6858f
commit 1d96d91
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 0 deletions.
diff --git a/src/Ad/InLine.php b/src/Ad/InLine.php
@@ -49,6 +49,34 @@ public function setAdTitle(string $value): self
         return $this;
     }
 
+    /**
+     * Set Ad serving ID
+     *
+     * @param string $value
+     *
+     * @return InLine
+     */
+    public function setAdServingId(string $value): self
+    {
+        $this->setScalarNodeCdata('AdServingId', $value);
+
+        return $this;
+    }
+
+    /**
+     * Set description
+     *
+     * @param string $value
+     *
+     * @return InLine
+     */
+    public function setDescription(string $value): self
+    {
+        $this->setScalarNodeCdata('Description', $value);
+
+        return $this;
+    }
+
     /**
      * @return string[]
      */

diff --git a/tests/DocumentTest.php b/tests/DocumentTest.php
@@ -21,6 +21,8 @@ public function testCreateInLineAdSection()
             ->setId('ad1')
             ->setAdSystem('Ad Server Name')
             ->setAdTitle('Ad Title')
+            ->setAdServingId('my-ad-server-id')
+            ->setDescription('Ad Description')
             ->addImpression('http://ad.server.com/impression', 'imp1');
 
         // create creative for ad section

diff --git a/tests/data/inlineAd.xml b/tests/data/inlineAd.xml
@@ -4,6 +4,8 @@
         <InLine>
             <AdSystem><![CDATA[Ad Server Name]]></AdSystem>
             <AdTitle><![CDATA[Ad Title]]></AdTitle>
+            <AdServingId><![CDATA[my-ad-server-id]]></AdServingId>
+            <Description><![CDATA[Ad Description]]></Description>
             <Impression id="imp1"><![CDATA[http://ad.server.com/impression]]></Impression>
             <Creatives>
                 <Creative id="013d876d-14fc-49a2-aefd-744fce68365b" adId="pre">