Skip to content

Commit

Permalink
back deprecated method
Browse files Browse the repository at this point in the history
  • Loading branch information
sokil committed Nov 2, 2017
1 parent d85e116 commit 9949bad
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ $ad1 = $document
->setId('ad1')
->setAdSystem('Ad Server Name')
->setAdTitle('Ad Title')
->setImpression('http://ad.server.com/impression');
->addImpression('http://ad.server.com/impression');

// create creative for ad section
$ad1->createLinearCreative()
Expand Down
10 changes: 10 additions & 0 deletions src/Ad/AbstractAdNode.php
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,16 @@ public function addImpression($url)
return $this;
}

/**
* @deprecated Ad may have multiple impressions, so use self::addImpression()
*
* @param string $url
*/
public function setImpression($url)
{
$this->addImpression($url);
}

/**
* Get previously set impression tracking url value
*
Expand Down

0 comments on commit 9949bad

Please sign in to comment.