Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctest doesn't compile with GHC 7.7 snapshot #55

Closed
peti opened this issue Aug 31, 2013 · 18 comments
Closed

doctest doesn't compile with GHC 7.7 snapshot #55

peti opened this issue Aug 31, 2013 · 18 comments

Comments

@peti
Copy link

peti commented Aug 31, 2013

Building doctest-0.9.7...
Preprocessing library doctest-0.9.7...
[ 1 of 13] Compiling Paths_doctest    ( dist/build/autogen/Paths_doctest.hs, dist/build/Paths_doctest.o )
[ 2 of 13] Compiling Interpreter      ( src/Interpreter.hs, dist/build/Interpreter.o )
[ 3 of 13] Compiling Help             ( src/Help.hs, dist/build/Help.o )
[ 4 of 13] Compiling Util             ( src/Util.hs, dist/build/Util.o )
[ 5 of 13] Compiling Runner.Example   ( src/Runner/Example.hs, dist/build/Runner/Example.o )
[ 6 of 13] Compiling Location         ( src/Location.hs, dist/build/Location.o )
[ 7 of 13] Compiling GhcUtil          ( src/GhcUtil.hs, dist/build/GhcUtil.o )

src/GhcUtil.hs:8:25: Module `Panic' does not export `ghcError'
@sol
Copy link
Owner

sol commented Aug 31, 2013

Thanks for the heads up. @kazu-yamamoto worked on this. But it seems that GHC HEAD changed again...

@kazu-yamamoto
Copy link
Collaborator

I'm not busy in September. So, I will try this again very soon.

@sol
Copy link
Owner

sol commented Sep 1, 2013

@kazu-yamamoto Thanks a lot!

@kazu-yamamoto
Copy link
Collaborator

Uhhm. I tested doctest HEAD with GHC HEAD. GHC HEAD can compile doctest HEAD. The test failures were exactly what I expected (i.e. future work). Am I missing something?

@peti
Copy link
Author

peti commented Sep 2, 2013

Duh, you are right! The build error I saw was caused by a dependency of doctest. I just misread the build log. :-( I am sorry for the false report.

@peti peti closed this as completed Sep 2, 2013
@kazu-yamamoto
Copy link
Collaborator

No problem!

@peti
Copy link
Author

peti commented Sep 6, 2013

@kazu-yamamoto, could you please check out the build log at http://hydra.cryp.to/build/12672/nixlog/1/raw? The doctest build fails, saying:

src/GhcUtil.hs:8:25: Module `Panic' does not export `ghcError'

@peti peti reopened this Sep 6, 2013
@kazu-yamamoto
Copy link
Collaborator

doctest 0.9.7 does not support GHC head. doctest head does support GHC head.

@peti
Copy link
Author

peti commented Sep 8, 2013

Is there any particular reason why the release version of doctest doesn't build with GHC 7.7.x?

@kazu-yamamoto
Copy link
Collaborator

It's up to @sol. Note that doctest head does not pass 5 test cases at this moment.

@sol
Copy link
Owner

sol commented Sep 9, 2013

@peti I see how this can be an issue for nix, but the GHC API is a moving target and I can't guarantee that Doctest always works with GHC HEAD. @kazu-yamamoto already took quite some effort to make it work (big thanks for that!) and we can cut a new release as soon as all tests pass. But I'm currently somewhat swamped, so any help with this is much appreciated.

@peti
Copy link
Author

peti commented Sep 9, 2013

@sol, thank you for the heads up. I have been trying to compile our package set in Nix with a recent snapshot of GHC, just to see how far that would go. It turns out that virtually nothing compiles, because some of the foundations won't build (such as test-framework, doctest, etc.), and almost all packages depend on some of those packages. So I started filing issues to make sure people are aware of the fact. I realize it's impossible to support GHC 7.7 at this time because -- strictly speaking -- there is no GHC 7.7. There's just a HEAD version of some Git repository. :-)

I am glad to see that Kazu and you make an effort to keep doctest working with a recent GHC snapshot. Thank you for your efforts. I'll look forward to a new release of doctest whenever it's ready. Once it comes out, I'll give this GHC 7.7 project another go.

@peti peti closed this as completed Sep 9, 2013
@kazu-yamamoto
Copy link
Collaborator

I recorded issues to describe what I'm fighting against now. See #57,#58,#59.

@kazu-yamamoto
Copy link
Collaborator

OK. All bugs have been fixed now.

@sol, I think you can release a new version. I will tackle cabal sandbox.

@sol
Copy link
Owner

sol commented Sep 11, 2013

#57 and #58 look good to me.

I still wonder whether #57 is a regression in GHC? You should always flush stderr if an error happened, right?

I think #59 does not really solve the underlying issue, I propose #60 here.

@kazu-yamamoto
Copy link
Collaborator

Now I don't think #57 is regression in GHC. Stderr of GHC has BlockBuffering Nothing after hDuplicateTo. So, no flushing is reasonable. GHC 7.6.3 flushes stderr even if it has BlockBuffering Nothing. It was strange.

@peti
Copy link
Author

peti commented Nov 27, 2013

I have a regression after the last doctest update. See http://hydra.cryp.to/build/25221/nixlog/15/raw for a complete build log. The problem seems to be that discardStaticFlags is not exported by the StaticFlag module. Admittedly, my ghc snapshot is old'ish, so this issue might not occur in more recent versions.

@sol
Copy link
Owner

sol commented Nov 28, 2013

@peti Yes, I guess your build is too old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants