Initialize GHC plugins #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since GHC-8.6 plugins need to be initialized on a per module basis. Without this any modules using plugins fail to compile inside doctest. This code is adapted from how this was fixed in haddock: https://github.com/haskell/haddock/pull/983/files#diff-a6119dd2da927bbff2c39eda86cdc733
|
Seems sensible enough and Travis likes it. I assume that if this breaks anyone, they'll come here and complain, so let's go for it. |
quasicomputational
added a commit
to quasicomputational/doctest
that referenced
this pull request
Apr 26, 2019
[skip ci]
quasicomputational
added a commit
that referenced
this pull request
Apr 26, 2019
Mention #224 in CHANGES.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GHC-8.6 plugins need to be initialized on a per module basis.
Without this any modules using plugins fail to compile inside doctest.
This code is adapted from how this was fixed in haddock:
https://github.com/haskell/haddock/pull/983/files#diff-a6119dd2da927bbff2c39eda86cdc733
I have a testcase which I used to verify this is working at: https://github.com/leonschoorl/doctest/blob/load-plugins-test/TestPlugins.hs
But it requires the
ghc-typelits-knownnatpackage to be installed, and I don't know how to integrate this into the testsuite.