Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pkg-configs section (#169) #185

Merged
merged 5 commits into from Dec 12, 2017
Merged

Add support for pkg-configs section (#169) #185

merged 5 commits into from Dec 12, 2017

Conversation

BlakeRain
Copy link
Contributor

Add support for pkg-configs in a Section which emits a pkgconfig-depends (ref issue #169).

@sol
Copy link
Owner

sol commented Jun 26, 2017

@BlakeRain Thanks a lot for working on this!

Regarding naming, I agree that we don't want to use Cabal's pkgconfig-depends. Still, I'm not yet sure whether I like pkg-confis. Other options:

  • pkg-config-dependencies - conveys meaning and is in line with dependencies
  • native-dependencies - I love this one

Opinions?

We also need to update the README.

@BlakeRain
Copy link
Contributor Author

The pkg-config-dependencies does indeed have merit. I'm worried that native-dependencies might be confused with extra-libraries.

@sol
Copy link
Owner

sol commented Jul 3, 2017

@BlakeRain pkg-config-dependencies or native-dependencies, you can make a call.

@ip1981
Copy link

ip1981 commented Aug 4, 2017

I think it should include pkg-config in name (it relies on pkg-config, right?), and should not have native (it is too vague; for me it's about cross-compilation).

@BlakeRain
Copy link
Contributor Author

This PR seems to have died (probably my fault). Is it worth resurrecting?

@sol
Copy link
Owner

sol commented Oct 12, 2017

@BlakeRain Yes, please!

@krakrjak
Merge pr185-iss169 with master
9c4a813 
 Conflicts:
	src/Hpack/Config.hs (Constructor call fixup)
	src/Hpack/Run.hs (kdiff3 automatic)
	test/Hpack/ConfigSpec.hs (small massage)
@krakrjak
Add missing toSection in test
73868a3
@krakrjak
Copy link
Contributor

krakrjak commented Nov 9, 2017

I've sent a PR to @BlakeRain with a merge fixup for his initial patch set.
https://github.com/krakrjak/hpack/tree/merge-hpack-pr185-iss169

@sol sol merged commit 7e61a5c into sol:master Dec 12, 2017
sol added a commit that referenced this pull request Dec 12, 2017
@sol
Merge pull request #185
4f8291e 
Add support for pkg-configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BlakeRain @sol @ip1981 @krakrjak