Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite any existing cabal file if it has been modified manually #215

Closed
wants to merge 5 commits into from

Conversation

sol
Copy link
Owner

@sol sol commented Nov 10, 2017

No description provided.

@sol sol changed the base branch from master to release-0.19.4 November 10, 2017 10:03
@sol
Copy link
Owner Author

sol commented Nov 10, 2017

Addresses commercialhaskell/stack#3383.

@mgsloan
Copy link
Contributor

mgsloan commented Nov 13, 2017

LGTM. Thanks a bunch for working on this!

@sol
Copy link
Owner Author

sol commented Nov 15, 2017

I made some minor modifications in c8a2065:

  • Always overwrite when created with hpack < 0.20.0
  • Never overwrite when hash is missing

In addition I added --force to the hpack executable. I think this is good to go from hpack's perspective.

@mgsloan @snoyberg I'll cut a release as soon as you guys give me an other thumbs-up and CI passes.

Copy link
Contributor

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up from me 👍

@sol sol closed this Nov 16, 2017
@sol
Copy link
Owner Author

sol commented Nov 16, 2017

On Hackage as 0.20.0.

@snoyberg
Copy link
Contributor

Thanks, PR to Stack sent to update. Looks like this'll make it into Stack 1.6.0 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants