Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode transaction from string, fix transaction serialization bug #65

Merged
merged 5 commits into from
May 14, 2024
Merged

Decode transaction from string, fix transaction serialization bug #65

merged 5 commits into from
May 14, 2024

Conversation

Tougee
Copy link
Contributor

@Tougee Tougee commented May 13, 2024

No description provided.

@Tougee Tougee mentioned this pull request May 13, 2024
Open
Shpota
Shpota requested changes May 13, 2024
View reviewed changes
Copy link
Member

@Shpota Shpota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution

src/main/kotlin/org/sol4k/Binary.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/sol4k/Transaction.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/sol4k/Transaction.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/sol4k/Transaction.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/sol4k/Transaction.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/sol4k/Transaction.kt Outdated Show resolved Hide resolved
@Tougee Tougee requested a review from Shpota May 14, 2024 02:57
@Shpota
Copy link
Member

Shpota commented May 14, 2024 •
edited

Hey @Tougee could you please check the linter again? Looks like you fixed the issues in the test files but not in the main source set. You can run ./gradlew ktlintCheck to execute all the checks locally. Also, it applies standard IntelliJ IDE formatting so you can just reformat it in the IDE and that should be enough.

@Shpota Shpota merged commit c4d950e into sol4k:main May 14, 2024
3 checks passed
@Shpota
Copy link
Member

Shpota commented May 14, 2024

Thank you @Tougee. The changes are now available in v0.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shpota Shpota Shpota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tougee @Shpota