Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result of literal hook ignored in runtime engine in dict and list functions #59

Closed
nimamg opened this issue Mar 15, 2024 · 3 comments · Fixed by #60
Closed

Result of literal hook ignored in runtime engine in dict and list functions #59

nimamg opened this issue Mar 15, 2024 · 3 comments · Fixed by #60

Comments

@nimamg
Copy link
Contributor

nimamg commented Mar 15, 2024

Although the literal hook is called in the _dict_ and _list_ functions in the runtime engine, its result is ignored (unlike the _str_, _int_, etc. functions) and if something is returned in the literal hook, it will not change the actual value in the instrumented program.

@nimamg
Copy link
Contributor Author

nimamg commented Mar 15, 2024

I'm not sure if these two hooks are just missed or is there actually a reason that the literal hook result is ignored in these hooks. I created a pull request that adds this functionality, but I'll be happy to discuss it if there is a reason it should be ignored.

@nimamg
Copy link
Contributor Author

nimamg commented Mar 21, 2024

Any updates on this?

@AryazE
Copy link
Collaborator

AryazE commented Mar 21, 2024

You are right. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants