Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pascal case for Enums, calculator program + Modified Hello program #12

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lostintime101
Copy link

Calculator example program Enums changed to Pascal case due to an issue on Playgrounds.
See: solana-playground/solana-playground#191

@lostintime101 lostintime101 changed the title Pascal case for Enums, calculator program Pascal case for Enums, calculator program + Modified Hello program Feb 20, 2024
@lostintime101
Copy link
Author

Have modified the "Hello" program, adding a missing instruction to create the user token account

Copy link
Collaborator

@mcintyre94 mcintyre94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would you mind updating the generated examples too? If you have the repo running locally you should be able to just run ./tests/compile-tests.sh. Then check in the updated files.

examples/hello.py Outdated Show resolved Hide resolved
@lostintime101
Copy link
Author

running ./tests/compile-tests.sh isn't doing much. The script seems to be looking for an executable 'seahorse' that isn't there

fsdfds

@mcintyre94
Copy link
Collaborator

Ah sorry, if you run cargo build first that'll compile it locally.

The idea of that script is that if we change the compiler code, we can re-compile a bunch of code and verify that the output either isn't changed, or is changed in the expected way. So it runs against the locally compiled version of seahorse, with whatever local changes you've made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants