Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMD-0096: Reward full priority fee to validators #96

Merged

Conversation

tao-stones
Copy link
Contributor

Reward 100% of priority fee to validator.

@tao-stones tao-stones marked this pull request as draft December 19, 2023 00:13
@diman-io
Copy link

Otherwise, a bribe program is just a matter of time

@mschneider
Copy link

mschneider commented Dec 20, 2023

lgtm! only drawback is not critical, we can monitor for metric inflation off-chain in lite-rpc etc. if it's a real concern

@tao-stones tao-stones marked this pull request as ready for review December 20, 2023 15:45
lheeger-jump
lheeger-jump previously approved these changes Dec 29, 2023
Copy link
Contributor

@lheeger-jump lheeger-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@lheeger-jump
Copy link
Contributor

The primary drawback mentioned is not actually an issue, because the leader will still lose the base fee and they get to decide on inclusion of transactions anyways.


## Drawbacks

100% rewarding priority fee allows leaders to artificially bump up priority fee.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already true in the current regime; the leader doesn't need to send any txs, they just reject all txs that don't have a prio fee large enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

@aeyakovenko
Copy link

Scheduler should prioritize based on

  • priority + base/2*CUs

@taozhu-chicago

That's the simple greedy choice for the validator

@buffalu
Copy link

buffalu commented Jan 4, 2024

i think this is a step in the right direction. however, i think it'd be good to also consider adding something similar to commission rate to priority fees and get those shared with stakers through auto-restaked SOL in stake accounts.

@CantelopePeel
Copy link

i think this is a step in the right direction. however, i think it'd be good to also consider adding something similar to commission rate to priority fees and get those shared with stakers through auto-restaked SOL in stake accounts.

please address this in a separate SIMD. i am happy with such a thing but its not a concern of this proposal.

@buffalu
Copy link

buffalu commented Jan 5, 2024

i think this is a step in the right direction. however, i think it'd be good to also consider adding something similar to commission rate to priority fees and get those shared with stakers through auto-restaked SOL in stake accounts.

please address this in a separate SIMD. i am happy with such a thing but its not a concern of this proposal.

that's fine with me, i will make another SIMD

@lheeger-jump
Copy link
Contributor

lheeger-jump commented Jan 6, 2024

Unless there are objections from core contributors, I will merge this SIMD on 08/01/2024.

Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I previously approved because I agree with the technical premise of this proposal. While proof reading, I noticed a few more things.

tao-stones and others added 4 commits January 10, 2024 09:08
Co-authored-by: ripatel-fd <ripatel+git@jumptrading.com>
Co-authored-by: ripatel-fd <ripatel+git@jumptrading.com>
@lheeger-jump
Copy link
Contributor

Lets merge this today please

@ripatel-fd
Copy link
Contributor

@t-nelson Any objections to merging this?

@lheeger-jump
Copy link
Contributor

LGTM, Merging

@slugmann321
Copy link

Shouldn't a big economic change like this require some discussion from the community?
The economics for validators will be hugely affected. Positively, but arguably at the expense of stakers/holders who will see increased supply issuance. Doesn't seem like a purely technical change to make. Where did this originate from?
Need to raise awareness of the change and arguably have some voting take place, IMO

@ripatel-fd
Copy link
Contributor

Shouldn't a big economic change like this require some discussion from the community? The economics for validators will be hugely affected. Positively, but arguably at the expense of stakers/holders who will see increased supply issuance. Doesn't seem like a purely technical change to make. Where did this originate from? Need to raise awareness of the change and arguably have some voting take place, IMO

@slugmann321 That is the entire point of the proposal process. This document is now a finalized draft where it can be discussed by the community. See the status: Draft tag at the beginning of the file.

@jacobcreech
Copy link
Contributor

@slugmann321 , as @ripatel-fd pointed out, we're now merged as a finalized draft. Moving from there to implemented can take multiple steps. Imo we do need guidance on when to take a feature gate through governance to get to implemented state.

@Ethan-000
Copy link

hi. wonder where can i see more discussion of this

@0xSol
Copy link

0xSol commented May 23, 2024

hi. wonder where can i see more discussion of this

Discord channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Standard SIMD with type Core
Projects
Status: SIMDs
Development

Successfully merging this pull request may close these issues.

None yet