-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMD-0096: Reward full priority fee to validators #96
SIMD-0096: Reward full priority fee to validators #96
Conversation
Otherwise, a bribe program is just a matter of time |
lgtm! only drawback is not critical, we can monitor for metric inflation off-chain in lite-rpc etc. if it's a real concern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
The primary drawback mentioned is not actually an issue, because the leader will still lose the base fee and they get to decide on inclusion of transactions anyways. |
|
||
## Drawbacks | ||
|
||
100% rewarding priority fee allows leaders to artificially bump up priority fee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already true in the current regime; the leader doesn't need to send any txs, they just reject all txs that don't have a prio fee large enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed
Scheduler should prioritize based on
@taozhu-chicago That's the simple greedy choice for the validator |
i think this is a step in the right direction. however, i think it'd be good to also consider adding something similar to commission rate to priority fees and get those shared with stakers through auto-restaked SOL in stake accounts. |
please address this in a separate SIMD. i am happy with such a thing but its not a concern of this proposal. |
that's fine with me, i will make another SIMD |
Unless there are objections from core contributors, I will merge this SIMD on 08/01/2024. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I previously approved because I agree with the technical premise of this proposal. While proof reading, I noticed a few more things.
Co-authored-by: ripatel-fd <ripatel+git@jumptrading.com>
Co-authored-by: ripatel-fd <ripatel+git@jumptrading.com>
Lets merge this today please |
@t-nelson Any objections to merging this? |
LGTM, Merging |
Shouldn't a big economic change like this require some discussion from the community? |
@slugmann321 That is the entire point of the proposal process. This document is now a finalized draft where it can be discussed by the community. See the |
@slugmann321 , as @ripatel-fd pointed out, we're now merged as a finalized draft. Moving from there to |
hi. wonder where can i see more discussion of this |
|
Reward 100% of priority fee to validator.