Improve token display name in detail view #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Add `useMetadata` to the `mint` display so that newer tokens' display name is shown (not just those in the registry) 2) Shift column order so mint/name column is always first and does not change when toggling from `Summary` to `Detailed`
|
@amilz is attempting to deploy a commit to the Solana Team on Vercel. A member of the Team first needs to authorize it. |
|
Any interest in this PR? |
|
closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating PR From solana-labs/solana#29968
Problem
Solana Explorer Token Details tab loses known token names for some tokens (my hunch is those with newer Metaplex metadata post token registry).
Example: Can be seen here where SAMO maintains token name but others do not:
Summary of Changes
useMetadatato themintdisplay so that newer tokens' display name is shown (not just those in the registry)SummarytoDetailedAchieved outcome--all tokens
Screen.Recording.2023-01-28.at.2.57.47.PM.mov
Fixes #
Issue 29604