Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

[Bug] move-native is not formatted correctly #237

Closed
brson opened this issue Jul 12, 2023 · 2 comments · Fixed by #244
Closed

[Bug] move-native is not formatted correctly #237

brson opened this issue Jul 12, 2023 · 2 comments · Fixed by #244
Assignees
Labels
bug Something isn't working

Comments

@brson
Copy link
Collaborator

brson commented Jul 12, 2023

It's not part of the workspace and doesn't end up examined by cargo xfmt.

Reformat it and add the correct command to CI.

@brson brson added the bug Something isn't working label Jul 12, 2023
@brson brson self-assigned this Jul 12, 2023
@nvjle
Copy link

nvjle commented Jul 12, 2023

Will xlint and xclippy also run?

@brson
Copy link
Collaborator Author

brson commented Jul 13, 2023

xlint already seems to run against it, probably because it is a custom program that ignores the workspace.

We can also run clippy on it in CI.

I don't know offhand how to run xfmt and xclippy on it - i was just thinking of running regular cargo fmt, but I'll look into what it would take to run the custom ones.

I know adding it to the workspace has been difficult in the past because being a cdylib causes some strange problems, but I have an idea of how it might be added to the workspace by not declaring it a cdylib (but still compiling it as one for production and tests).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants