This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Destroy vectors with elements #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksolana
approved these changes
Sep 17, 2023
ksolana
reviewed
Sep 17, 2023
| /// | ||
| /// Unsafe because the provided type must be correct. | ||
| // | ||
| // todo: We should probably just leak the vector instead of |
There was a problem hiding this comment.
can we add a flag that will help switch between leak vs. drop. that'd be easier to test i guess. maybe as a separate patch if you think this is a good idea.
There was a problem hiding this comment.
Yeah we can do that separately.
|
!help |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the vec_destroy runtime call for vectors with elements, including other vectors and structs.
This patch makes the encode_128 test pass, as described in #333, but it causes encode_129 to fail (because move-native serializes a deeply nested type that should instead produce a recursion-limit error). I filed #367 about encode_129.
Fixes #333