This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Refactor write to file of LLVM module moving it to Module #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chidocibot
added a commit
to dmakarov/move
that referenced
this pull request
Sep 18, 2023
chidocibot
force-pushed
the
dm/llmod
branch
from
7910331
to
252d921
Compare
brson
approved these changes
Sep 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Dependency on llvm::Module is convoluted, requiring mutable references. This change moves the function that writes LLVM module to a file into the Module implementation, simplifying dependency on llvm::Module.
Test Plan
Non functional change, all tests should pass.