Fix - callx encoding
#491
Merged
Fix - callx encoding
#491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #491 +/- ##
==========================================
+ Coverage 89.69% 89.70% +0.01%
==========================================
Files 23 23
Lines 10109 10123 +14
==========================================
+ Hits 9067 9081 +14
Misses 1042 1042
|
Lichtso
force-pushed
the
fix/callx_encoding
branch
from
bbbe89c
to
9f00ada
Compare
alessandrod
reviewed
Jul 28, 2023
src/elf.rs
Outdated
| @@ -230,6 +230,11 @@ impl SBPFVersion { | |||
| self != &SBPFVersion::V1 | |||
| } | |||
|
|
|||
| /// Use src reg instead of imm in callx | |||
| pub fn fix_callx_encoding(&self) -> bool { | |||
There was a problem hiding this comment.
nit: call it callx_uses_src_reg or something? "fix" is generic: what was broken?
how was it fixed?
…field instead of the imm field.
Lichtso
force-pushed
the
fix/callx_encoding
branch
from
9f00ada
to
b84dcbd
Compare
alessandrod
approved these changes
Jul 28, 2023
18 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently callx encodes its target register in the
immfield, but it should use thesrcregister field instead.The instruction info in llvm would need to be patched here:
https://github.com/solana-labs/llvm-project/blob/7b8db05b564faffb522434b73b7082662171f94a/llvm/lib/Target/SBF/SBFInstrInfo.td#L526