Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token v3: Native mint supply should increase/decrease as users wrap/close accounts #506

Closed
CriesofCarrots opened this issue Sep 21, 2020 · 4 comments
Closed

token v3: Native mint supply should increase/decrease as users wrap/close accounts #506

CriesofCarrots opened this issue Sep 21, 2020 · 4 comments
Milestone
Token 3

Comments

@CriesofCarrots
Copy link
Contributor

The native mint in token2 currently reports 0 supply, regardless of actual wrapped accounts in circulation.
Update InitializeAccount and CloseAccount processing code to update native mint supply appropriately.
@CriesofCarrots CriesofCarrots added this to the Token 2.1 milestone Sep 21, 2020
@CriesofCarrots CriesofCarrots self-assigned this Sep 21, 2020
@CriesofCarrots
Copy link
Contributor Author

This adjustment requires passing the native-mint account into CloseAccount instructions. Punting until v3.

@mvines mvines reopened this Sep 22, 2020
@mvines mvines modified the milestones: Token 2.1, Token 3 Sep 22, 2020
@mvines mvines changed the title Native mint supply should increase/decrease as users wrap/close accounts token v3: Native mint supply should increase/decrease as users wrap/close accounts Sep 22, 2020
@t-nelson
Copy link
Contributor

@CriesofCarrots

This seems to be covered by #374, mind if we close this one?

@CriesofCarrots CriesofCarrots removed their assignment Jan 29, 2021
@CriesofCarrots
Copy link
Contributor Author

@CriesofCarrots

This seems to be covered by #374, mind if we close this one?

Sure, I've no strong opinion, if you think the other issue details this need sufficiently.

@mvines
Copy link
Member

mvines commented Jan 29, 2021

Passing the mint into CloseAccount is not really viable anymore with Token2 and since we've basically implicitly that there'll never be a Token3 in the foreseeable future I don't think we need to track this limitation

@mvines mvines closed this as completed Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Token 3
Development

No branches or pull requests
3 participants
@t-nelson @mvines @CriesofCarrots