-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- stake_pool: implement js bindings for token metadata instructions #3441
- stake_pool: implement js bindings for token metadata instructions #3441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! We still have a couple of things to work out, and feel free to split out your other changes in a separate PR
BufferLayout.blob(METADATA_MAX_NAME_LENGTH, 'name'), | ||
BufferLayout.blob(METADATA_MAX_SYMBOL_LENGTH, 'symbol'), | ||
BufferLayout.blob(METADATA_MAX_URI_LENGTH, 'uri'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably won't work -- the stake pool program is expecting a Borsh-encoded String
, which means 4 bytes for the length, followed by utf-8 bytes
# Conflicts: # stake-pool/js/test/instructions.test.ts
Closing in favor of #5103 |
Fixes #3369