Feat: SNS Realloc Name Account #3955
Conversation
stegaBOB
force-pushed
the
stegaBOB/feat/sns-realloc
branch
from
c4513c6
to
c09d28a
Compare
stegaBOB
force-pushed
the
stegaBOB/feat/sns-realloc
branch
from
c09d28a
to
cec9e65
Compare
stegaBOB
force-pushed
the
stegaBOB/feat/sns-realloc
branch
from
5ac47f7
to
dbc3794
Compare
|
The lack of JS tests here is a bit concerning. I think I'll spend some time at some point before this is ready to go to just write a few to make sure my changes function as they should. |
Co-authored-by: Jon Cinque <joncinque@pm.me>
Co-authored-by: Jon Cinque <joncinque@pm.me>
Co-authored-by: Jon Cinque <joncinque@pm.me>
Co-authored-by: Jon Cinque <joncinque@pm.me>
|
do you intend to add the JS tests in this PR or with later work? Also, it looks like the |
|
Whoops! I'll fix that. As for the TS tests, I'd prefer not to write them at all haha. If you think it's fine to merge in as it is now without tests, then by all means I guess? I don't have the bandwidth right now to write TS tests from scratch so it might take little while if the tests were to be in this PR. |
|
That's fine, I'll merge this as is. Do you mind adding an issue for the JS tests? |
|
Awesome! And yep, heres the issue: #4004 |
* add new realloc ix * add tests * update param order to be consistent with other builders * add realloc ix to instructions.ts * ts bindings for realloc * ts linting * fix logs and clippy arithmetic * satisfy clippy * Update name-service/program/src/instruction.rs Co-authored-by: Jon Cinque <joncinque@pm.me> * Update name-service/program/src/instruction.rs Co-authored-by: Jon Cinque <joncinque@pm.me> * docs nits * fix import ordering * Update name-service/program/tests/functional.rs Co-authored-by: Jon Cinque <joncinque@pm.me> * blockhash nits * Update name-service/js/src/bindings.ts Co-authored-by: Jon Cinque <joncinque@pm.me> * fix hashed_name naming Co-authored-by: Jon Cinque <joncinque@pm.me>
Pretty straightforward PR. This PR adds the ability to realloc the SNS name account.
Todo: