Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Solana to 1.16.1 and Rust to 1.69 #4592

Merged
merged 17 commits into from
Jun 26, 2023
Merged

Conversation

joncinque
Copy link
Contributor

Problem

The 1.16 Solana crates are out, but SPL is still on 1.14 and needs the new functionality.

Solution

Update the:

  • rust version to 1.69
  • nightly to 2023-04-19
  • solana tools to 1.16.1
  • solana crates to 1.16.1
  • borsh to 0.10

And fix:

  • new clippy warnings
  • deprecated warnings in the new solana crates

This may take some time to usher through CI, so marking as a draft

ASISBusiness

This comment was marked as spam.

@joncinque joncinque force-pushed the rustup branch 3 times, most recently from 8ef28ab to 14fe75f Compare June 23, 2023 22:24
@joncinque joncinque marked this pull request as ready for review June 23, 2023 22:57
@joncinque
Copy link
Contributor Author

All right, this is finally good to go!

samkim-crypto
samkim-crypto previously approved these changes Jun 24, 2023
Copy link
Contributor

@samkim-crypto samkim-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes. Looks good to me!

@govindtripathi

This comment was marked as spam.

@joncinque
Copy link
Contributor Author

Rebased this on top of #4595, so once it passes CI, will merge!

@mergify mergify bot dismissed samkim-crypto’s stale review June 26, 2023 11:43

Pull request has been modified.

@joncinque joncinque merged commit 9e6ab03 into solana-labs:master Jun 26, 2023
37 checks passed
@joncinque joncinque deleted the rustup branch June 26, 2023 12:42
buffalojoec pushed a commit to buffalojoec/solana-program-library-jonc that referenced this pull request Jun 26, 2023
The 1.16 Solana crates are out, but SPL is still on 1.14 and needs the
new functionality.

Update the:

* rust version to 1.69
* nightly to 2023-04-19
* solana tools to 1.16.1
* solana crates to 1.16.1
* borsh to 0.10

And fix:

* new clippy warnings
* deprecated warnings in the new solana crates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants