token-2022: modify onchain extra metas helper #6089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
buffalojoec
force-pushed
the
01-08-token-2022_repair_offchain_extra_metas_helper
branch
from
73724a8
to
ce7a81e
Compare
buffalojoec
force-pushed
the
01-08-token-2022_repair_onchain_extra_metas_helper
branch
from
3acf5d2
to
f2acf5c
Compare
buffalojoec
force-pushed
the
01-08-token-2022_repair_offchain_extra_metas_helper
branch
from
ce7a81e
to
c03c8df
Compare
buffalojoec
force-pushed
the
01-08-token-2022_repair_onchain_extra_metas_helper
branch
from
f2acf5c
to
da95eeb
Compare
buffalojoec
force-pushed
the
01-08-token-2022_repair_offchain_extra_metas_helper
branch
from
c03c8df
to
a9cda55
Compare
buffalojoec
force-pushed
the
01-08-token-2022_repair_onchain_extra_metas_helper
branch
from
da95eeb
to
eb936aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, Token2022's onchain extra metas helper is being repaired in a
similar fashion to its offchain helper. However, since we already required the
parameters for a
transfer_checkedinstruction and were building it within theinvoke_transfer_checked(..)function, there's no need to deprecate anythinghere.
Draft: Still need to decide how best to write some tests for this without
requiring an additional function like before.