transfer hook: add new offchain helper #6099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
buffalojoec
force-pushed
the
01-09-transfer_hook_add_new_offchain_helper
branch
2 times, most recently
from
21f958e
to
15ddbc8
Compare
This was referenced Jan 10, 2024
joncinque
previously approved these changes
Jan 10, 2024
mergify
bot
dismissed
joncinque’s stale review
Pull request has been modified.
joncinque
previously approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Bah the embed isn't working: https://media.giphy.com/media/H4zaKzL5e7ypqn10zi/giphy.gif
This was referenced Jan 10, 2024
buffalojoec
force-pushed
the
01-09-transfer_hook_add_new_offchain_helper
branch
from
262663a
to
3700ef4
Compare
mergify
bot
dismissed
joncinque’s stale review
Pull request has been modified.
Merge activity
|
buffalojoec
added a commit
that referenced
this pull request
Jan 11, 2024
This PR adds a new offchain helper for creating a `TransferChecked` instruction with the necessary accounts metas for a transfer hook `ExecuteInstruction` to Token2022, deprecating the old one. As described in #6064, the original offchain helper in Token2022 was being used incorrectly to resolve extra account metas. Rather than providing the SPL Transfer Hook interface helper with a valid `ExecuteInstruction`, the original Token2022 helper was actually providing it with a transfer instruction, causing erroneous account resolution. Taking advantage of the more secure SPL Transfer Hook interface offchain helper provided in #6099, this new offchain helper creates a `TransferChecked` instruction and calls `add_extra_account_metas_for_execute(..)`, providing the keys used to build the transfer instruction. Note: unlike the deprecated helper in #6099, the deprecated offchain helper in Token2022 *is* in fact inaccurately resolving account metas for certain use cases, thus it should be vigilantly avoided.
buffalojoec
added a commit
that referenced
this pull request
Jan 11, 2024
Following up from the new helpers added in #6099 and #6100, there's a transfer hook test in `program-2022-test` that's using the now-deprecated helper to build a swap instruction for the test program. This PR replaces that bit of code to use the new helper from `spl_transfer_hook_interface`. Note: The test in question is designed to test Token2022's `invoke_transfer_checked(..)` on-chain helper, *not* the offchain helpers. So, it's appropriate to use the offchain helper directly from the interface crate for this step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new offchain helper for adding the necessary account metas for an
ExecuteInstructionto the SPL Transfer Hook interface, deprecating the oldone.
As described in #6064, the offchain helper in Token2022 was using the original
offchain helper from the SPL Transfer Hook interface incorrectly when resolving
extra account metas for a transfer.
In order to provide a safer, more robust helper, this new function takes the
instruction, fetch account data function, as well as the individual arguments
for
instruction::execute(..). This will help to ensure Token2022 as well asanyone else using the helpers from the SPL Transfer Hook interface are properly
resolving the necessary additional accounts.
Note: Although deprecated, the original helper in the SPL Transfer Hook
interface is not broken. It's just less safe to use than this new helper, since
it can easily be misused.