fix: do not modify transaction during simulation

solana-labs · Apr 13, 2022 · f9175dd · f9175dd
1 parent e707c2b
commit f9175dd
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/connection.ts b/src/connection.ts
@@ -3878,7 +3878,14 @@ export class Connection {
   ): Promise<RpcResponseAndContext<SimulatedTransactionResponse>> {
     let transaction;
     if (transactionOrMessage instanceof Transaction) {
-      transaction = transactionOrMessage;
+      let originalTx: Transaction = transactionOrMessage;
+      transaction = new Transaction({
+        recentBlockhash: originalTx.recentBlockhash,
+        nonceInfo: originalTx.nonceInfo,
+        feePayer: originalTx.feePayer,
+        signatures: [...originalTx.signatures],
+      });
+      transaction.instructions = transactionOrMessage.instructions;
     } else {
       transaction = Transaction.populate(transactionOrMessage);
     }
@@ -3888,11 +3895,7 @@ export class Connection {
     } else {
       let disableCache = this._disableBlockhashCaching;
       for (;;) {
-        if (!transaction.recentBlockhash) {
-          transaction.recentBlockhash = await this._recentBlockhash(
-            disableCache,
-          );
-        }
+        transaction.recentBlockhash = await this._recentBlockhash(disableCache);
 
         if (!signers) break;