Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated pnpm version in package.json #1295

Closed
influentcoder opened this issue May 11, 2023 · 2 comments · Fixed by #1310
Closed

Outdated pnpm version in package.json #1295

influentcoder opened this issue May 11, 2023 · 2 comments · Fixed by #1310
Labels
bug Something isn't working released

Comments

@influentcoder
Copy link

Overview

When using pnpm with corepack, the pnpm version is taken from package,json, which is currently 7.17.0. This is causing an issue because the lockfileVersion is 6.0 and this lockfile version is supported only by pnpm 8+.

Steps to reproduce

$ docker run -it ubuntu bash
$ apt-get update && apt-get install -y curl git
$ curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh | bash && source ~/.bashrc && nvm install 18
$ corepack enable && corepack prepare pnpm@latest --activate
$ git clone https://github.com/solana-labs/solana-web3.js.git
$ cd solana-web3.js/
$ pnpm -v  # 7.17.0 :(
$ pnpm install
Scope: all 10 workspace projects
 WARN  Ignoring broken lockfile at /solana-web3.js: Lockfile /solana-web3.js/pnpm-lock.yaml not compatible with current pnpm

Description of bug

I expected pnpm version to be 8+ (probably 8.5.0), but it was 7.17.0, and could not make use of the existing pnpm-lock.yaml .

The fix is to change the package.json from the root source folder. Change this:

"packageManager": "pnpm@7.17.0",

With this:

"packageManager": "pnpm@8.5.0",

Happy to raise a pull request for this if someone can agree on the proposed fix, thanks!

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.77.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants