fix: use the native fetch() in Node wherever supported
#1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Summary Folks are having trouble using the `node-fetch` polyfill with certain RPC providers that: * use chunked-transfer encoding * don't send a zero-sized chunk before closing the socket `node-fetch` doesn't like this, and fatals. One easy thing we can do while we figure this all out is to use the _native_ `fetch()` API included in Node 18+ by default and 17.5+ behind an experimental flag. Fixes #1418 in Node 18+. # Test Plan CI run.
mcintyre94
approved these changes
Jul 28, 2023
|
🎉 This PR is included in version 1.78.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: use the native
fetch()in Node wherever supportedSummary
Folks are having trouble using the
node-fetchpolyfill with certain RPC providers that:node-fetchdoesn't like this, and fatals.One easy thing we can do while we figure this all out is to use the native
fetch()API included in Node 18+ by default and 17.5+ behind an experimental flag.Fixes #1418 in Node 18+.
Test Plan
CI run.