Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the native fetch() in Node wherever supported #1447

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix: use the native fetch() in Node wherever supported #1447

merged 1 commit into from
Jul 28, 2023

Commits on Jul 27, 2023

  1. fix: use the native fetch() in Node wherever supported 

    # Summary

Folks are having trouble using the `node-fetch` polyfill with certain RPC providers that:

* use chunked-transfer encoding
* don't send a zero-sized chunk before closing the socket

`node-fetch` doesn't like this, and fatals.

One easy thing we can do while we figure this all out is to use the _native_ `fetch()` API included in Node 18+ by default and 17.5+ behind an experimental flag.

Fixes #1418 in Node 18+.

# Test Plan

CI run.
    @steveluscher
    steveluscher committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    096f6df View commit details
    Browse the repository at this point in the history