refactor(experimental): make signTransaction assert the transaction is fully signed; add partiallySignTransaction
#1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
I'm not 1000% sure this is the right API, so please do ponder it with me. |
… is fully signed; add `partiallySignTransaction`
steveluscher
force-pushed
the
11-10-refactor_experimental_make_signTransaction_assert_the_transaction_is_fully_signed_add_partiallySignTransaction_
branch
from
eaf1e49
to
cf65b9c
Compare
lorisleiva
approved these changes
Nov 10, 2023
steveluscher
deleted the
11-10-refactor_experimental_make_signTransaction_assert_the_transaction_is_fully_signed_add_partiallySignTransaction_
branch
|
🎉 This PR is included in version 1.87.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
lorisleiva
added a commit
that referenced
this pull request
Nov 16, 2023
…gner implementation (#1850) Fix the typecheck error of `@solana/signers` in CI/CD. ### Problem The implementation of the `KeyPairSigner` uses the `signTransaction` function from `@solana/transactions` under the hood which [was recently updated](#1820) to also assert the transaction is fully signed. Therefore, the mocked return value was giving a type error because it did not provide a `IFullySignedTransaction` as expected. ### Solution Use the new `partiallySignTransaction` function from `@solana/transactions` instead of `signTransaction` which does not assert the transaction is full signed (and is equivalent to the old behavior of the `signTransaction` function).
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I feel like in the common case of calling
signTransactionyou will want to end up with a fully signed (ie. landable) transaction, and that partially signing a transaction is more of the edge case.Test Plan